Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index error and display fsleyes command #2432

Merged
merged 3 commits into from Sep 11, 2019
Merged

Fix index error and display fsleyes command #2432

merged 3 commits into from Sep 11, 2019

Conversation

charleygros
Copy link
Member

@charleygros charleygros commented Sep 11, 2019 •
edited by jcohenadad

Done:

Done! To view results, type:
fsleyes t2.nii.gz t2_denoised.nii.gz &
  • Change the default value of verbose: set to 1 instead of 0.

Fixes #2430.

NB: We will be able to answer this issue: http://forum.spinalcordmri.org/t/sct-denoising-onlm-error-sct-version-4-0-2/157

@charleygros charleygros added bug category: fixes an error in the code enhancement category: improves performance/results of an existing feature card:TO_REVIEW labels Sep 11, 2019
@charleygros charleygros self-assigned this Sep 11, 2019
gmotzespina
gmotzespina approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@gmotzespina gmotzespina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jcohenadad jcohenadad removed the enhancement category: improves performance/results of an existing feature label Sep 11, 2019
@jcohenadad
Copy link
Member

p.s. i removed the label "enhancement" (there can only be one category label)

jcohenadad
jcohenadad approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome! thank you so much! could you please also answer the user on the forum?
thanks!!!

@jcohenadad jcohenadad added this to the 4.0.3 milestone Sep 11, 2019
@jcohenadad
Copy link
Member

p.s. when answering the user (after merging to master), mention that he can already get (and test) the fix from master, and that we will create a new SCT version 4.0.3 with the fix.

@charleygros charleygros merged commit 22f44e7 into master Sep 11, 2019
@charleygros charleygros deleted the cg/denoising-fix-index-error branch September 11, 2019 15:05
jcohenadad pushed a commit that referenced this pull request Dec 18, 2019
@charleygros
Merge pull request #2432 from neuropoly/cg/denoising-fix-index-error
1e909e3 
Fix index error and display fsleyes command

Former-commit-id: e4e4982dd2ac7890e0eab36add5b0fbc762520eb [formerly db7f774 [formerly 22f44e7]]
Former-commit-id: a12fc8f3de7ecd5d3fb998fd156d221b6d3cf8ff
Former-commit-id: 22eb333
jcohenadad pushed a commit that referenced this pull request Dec 18, 2019
@charleygros
Merge pull request #2432 from neuropoly/cg/denoising-fix-index-error
db7f774 
Fix index error and display fsleyes command

Former-commit-id: 22f44e7
@joshuacwnewton joshuacwnewton mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad approved these changes

@gmotzespina gmotzespina gmotzespina approved these changes

Assignees

@charleygros charleygros

Labels
bug category: fixes an error in the code sct_denoising_onlm context:
Projects
None yet
Milestone
4.1.0
3 participants
@charleygros @jcohenadad @gmotzespina