Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QC sct_get_centerline #2784

Merged
merged 5 commits into from Jul 15, 2020
Merged

Implement QC sct_get_centerline #2784

merged 5 commits into from Jul 15, 2020

Conversation

alexfoias
Copy link
Contributor

Fixes #2780

I tried with data from https://github.com/spine-generic/data-single-subject.

Here are some screenshots.

Screen Shot 2020-07-10 at 3 05 38 PM
Screen Shot 2020-07-10 at 3 05 45 PM

@alexfoias
Copy link
Contributor Author

@charleygros @jcohenadad Your feedback is welcomed on this new feature. thanks.

@jcohenadad jcohenadad marked this pull request as ready for review July 10, 2020 19:55
jcohenadad
jcohenadad approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome contribution! 💯

i let you merge in case you want to add minor stuff

@jcohenadad jcohenadad added enhancement category: improves performance/results of an existing feature sct_get_centerline context: sct_qc context: labels Jul 10, 2020
@jcohenadad jcohenadad added this to the 4.3.1 milestone Jul 10, 2020
@jcohenadad jcohenadad added feature category: new functionality and removed enhancement category: improves performance/results of an existing feature labels Jul 10, 2020
@jcohenadad jcohenadad mentioned this pull request Jul 14, 2020
Closed
@jcohenadad jcohenadad merged commit d46d531 into master Jul 15, 2020
@jcohenadad jcohenadad deleted the af/qc_sct_get_centerline branch July 15, 2020 20:26
Drulex pushed a commit to Drulex/spinalcordtoolbox that referenced this pull request Sep 30, 2020
@alexfoias @jcohenadad @Drulex
Implement QC sct_get_centerline (spinalcordtoolbox#2784)
e4c6b5d 
* add qc path

* add sct_get_centerline option

* initial qc

* add label to centerline

Co-authored-by: Julien Cohen-Adad <jcohen@polymtl.ca>
@joshuacwnewton joshuacwnewton mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad approved these changes

Assignees
No one assigned
Labels
feature category: new functionality sct_get_centerline context: sct_qc context:
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Create QC for sct_get_centerline optic method
2 participants
@alexfoias @jcohenadad