Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD: Re-enable showing version text underneath logo #3021

Merged
merged 1 commit into from Nov 11, 2020

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Nov 9, 2020

Related Issues/PRs

Fixes #3015. (#3015 (comment))

@joshuacwnewton joshuacwnewton marked this pull request as ready for review November 9, 2020 13:48
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it is showing the PR number, we need to fetch the version.txt from the release branch, I think.

@joshuacwnewton
Copy link
Member Author

joshuacwnewton commented Nov 9, 2020

Currently it is showing the PR number, we need to fetch the version.txt from the release branch, I think.

That's because RTD is generating the docs from the PR, so in this case, the version is the PR number. It's similar to the warning:

This page was created from a pull request.

If this were merged, then the version would display as latest, stable, 5.0.0, etc. depending on the version selected on RTD. (Same as https://ivadomed.org)

@joshuacwnewton joshuacwnewton added the documentation category: readthedocs, sourceforge, or SCT courses label Nov 9, 2020
@joshuacwnewton joshuacwnewton added this to the next-release milestone Nov 9, 2020
@jcohenadad
Copy link
Member

@joshuacwnewton thank you for the clarification, i thought that "stable" was not displayed, but instead would show the latest stable version. It is clearer now.

Just to be sure: how are "latest" and "stable" defined? Is it a feature in RTD that would automatically link "latest" with master (or the new "main"), and "stable" with the latest release?

@joshuacwnewton
Copy link
Member Author

Just to be sure: how are "latest" and "stable" defined? Is it a feature in RTD that would automatically link "latest" with master (or the new "main"), and "stable" with the latest release?

Yes, precisely. latest is set using a drop-down menu:

Screenshot from 2020-11-11 10-05-55

For stable, From How we envision versions working:

You should push a tag for each version of your project. These tags should be numbered in a way that is consistent with semantic versioning. This will map to your stable branch by default.

We in fact are parsing your tag names against the rules given by PEP 440. This spec allows “normal” version numbers like 1.4.2 as well as pre-releases. An alpha version or a release candidate are examples of pre-releases and they look like this: 2.0a1.

We only consider non pre-releases for the stable version of your documentation.

@jcohenadad jcohenadad merged commit 5eae6da into master Nov 11, 2020
@jcohenadad jcohenadad deleted the jn/3015-show-version-text branch November 11, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation category: readthedocs, sourceforge, or SCT courses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tag-based release versions to RTD
2 participants