sct_run_batch: handle the case of unexecutable script #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either sets the script itself to executable if the output directory is the current working directory, or sets the output directory copy to executable and uses that.
|
I can confirm this solves the issue described in #3030 and on the forum post . Thanks! |
jcohenadad
approved these changes
Nov 11, 2020
jcohenadad
added
enhancement
jcohenadad
deleted the
cfh/3030_run-batch_deal-with-non-executable-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either sets the script itself to executable if the output directory is the current working directory, or sets the output directory copy to executable and uses that.
This should resolve #3030.
Potential improvement:
Right now,
sct_run_batchcopies the user's script to the output directory, in the event the current working directory is the output directory there is no copy made. In this case I opted to modify the original script, which is perhaps distasteful, but I feel it is relatively harmless. If others disagree, we could make a copy with a suffix and modify the permissions on that.