Fix unit_testing/test_labels.py::test_remove_missing_labels #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulex
added
bug
Drulex
force-pushed
the
aj/3153-fix_test_missing_labels
branch
from
571a24d
to
7e6b511
Compare
|
Amazing, thank you for taking this on. I'll take a look momentarily. |
|
Woops looks like I broke something. Will look. |
….value directly instead of relying on membership check with "in" operator.
Drulex
force-pushed
the
aj/3153-fix_test_missing_labels
branch
from
7e6b511
to
5160e3d
Compare
|
CI failed because wsl couldn't be installed on windows (https://travis-ci.com/github/neuropoly/spinalcordtoolbox/jobs/475181141#L45)... |
- don't compare all voxels, only labels - spotcheck the relevant labels - use actual labels as test param instead of image
Drulex
force-pushed
the
aj/3153-fix_test_missing_labels
branch
from
5160e3d
to
4b62fab
Compare
|
ping @kousu |
|
@Drulex I can review as well, if that's alright? 🙂 |
There was a problem hiding this comment.
This PR is fixing 2 issues, right?
- Broken test (because of wrong input data)
- Slow, inefficient test
If so, it might be good to clarify the issue description, as #3153 only reports 1).
joshuacwnewton
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
GitHub
PR contents
Description
Closes #3153