Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate PyMARE into image-based meta-analysis estimators #211

Closed
tsalo opened this issue May 11, 2020 · 4 comments · Fixed by #273
Closed

Integrate PyMARE into image-based meta-analysis estimators #211

tsalo opened this issue May 11, 2020 · 4 comments · Fixed by #273
Labels
refactoring Requesting changes to the code which do not impact behavior
Milestone

Comments

@tsalo
Copy link
Member

tsalo commented May 11, 2020

Continues from neurostuff/PyMARE#31 (comment).

@tyarkoni Do you want to get this merged before 0.0.2? I remembered that there's a big bug in 0.0.1 and now that it should be fairly easy to deploy releases, I was thinking it would be good to release 0.0.2 soonish.

@tsalo tsalo added the refactoring Requesting changes to the code which do not impact behavior label May 11, 2020
@tyarkoni
Copy link
Contributor

Your call, but I don't see a problem releasing 0.0.2 ASAP, and then 0.0.3 (or maybe even 0.1!) as soon as the IBMA stuff is ready, whether that's next week or 6 months from now. :)

@tsalo tsalo added this to the 0.0.3 milestone May 11, 2020
@tsalo
Copy link
Member Author

tsalo commented May 11, 2020

Okay thanks! I've added this issue to a 0.0.3 milestone. Feel free to rename that to 0.1 if you feel like that makes more sense.

I'm going to make a 0.0.2 release pretty much as soon as #209 is resolved, so that the latest stable release doesn't have those frustrating I/O bugs that are present in 0.0.1.

@tsalo
Copy link
Member Author

tsalo commented May 20, 2020

Are your changes going to go into #163 or a different branch/PR?

@tyarkoni
Copy link
Contributor

Different branch for sure. I think #163 will probably end up being abandoned (but let's leave it there for now just in case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Requesting changes to the code which do not impact behavior
Projects
Development

Successfully merging a pull request may close this issue.

2 participants