Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duecredit #694

Closed
tsalo opened this issue Jun 2, 2022 · 0 comments · Fixed by #736
Closed

Remove duecredit #694

tsalo opened this issue Jun 2, 2022 · 0 comments · Fixed by #736
Labels
good first issue Good for newcomers. Equivalent to "very low" effort. impact: low Estimated low impact task maintenance Issues/PRs related to maintenance/infrastructure. priority: low Not urgent

Comments

@tsalo
Copy link
Member

tsalo commented Jun 2, 2022

Summary

Duecredit is currently an optional dependency, and I don't think many people use it. I also think that the docstrings' BibTeX references and plans for improved workflow boilerplates could be good enough for most users.

@jdkent have you thought about how the NIMADS CLI might generate boilerplates? Or will it not?

Additional details

Fewer dependencies to think about, and less work for devs when adding a tool or method.

Next steps

  1. Remove the duecredit dependency group.
  2. Remove the duecredit stub file.
  3. Remove uses of duecredit from the codebase.
  4. Remove the references.py file.
@tsalo tsalo added good first issue Good for newcomers. Equivalent to "very low" effort. priority: low Not urgent impact: low Estimated low impact task maintenance Issues/PRs related to maintenance/infrastructure. labels Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers. Equivalent to "very low" effort. impact: low Estimated low impact task maintenance Issues/PRs related to maintenance/infrastructure. priority: low Not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant