Bugfix/ordered dict #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 84.07% 84.09% +0.02%
==========================================
Files 47 47
Lines 3881 3886 +5
==========================================
+ Hits 3263 3268 +5
Misses 618 618
Continue to review full report at Codecov.
|
granrothge
force-pushed
the
bugfix/ordered_dict
branch
from
7ef27e8
to
5c4e661
Compare
|
I changed to the if not isinstance(scans_dict, collections.OrderedDict) structure and added tests to to check this portion of the code. It should increase the code coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the required input for a collection of scans from dict to ordered dict. This fixes a problem of strange ordering caused by the python ordering keys for memory conservation. The tests were updated to reflect this change.