Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce stack frame size for parser functions #16

Open
neverRare opened this issue Oct 16, 2021 · 0 comments
Open

Reduce stack frame size for parser functions #16

neverRare opened this issue Oct 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@neverRare
Copy link
Owner

neverRare commented Oct 16, 2021

As found out in #14, the parser functions have huge stack frame size that causes stack overflow too early even for parsing codes that isn't deeply nested.

This may also be an opportunity to refactor the parser codes.


Update: With handful of guess-works without actually measuring stack usage, I found out that building in release mode helps significantly. It seems like majority of stack values are debug stuffs. Even better, using Linux (I'm using Alpine WSL) instead of Windows also help even in debug mode. Thus, this seems like a Windows issue (MSVC issue?). Nevertheless, this still hints memory issue within the parser and could annoy contributors using Windows, so it is still better to address this issue, but this wouldn't be prioritized.

@neverRare neverRare added the enhancement New feature or request label Oct 17, 2021
@neverRare neverRare added this to To do in Development via automation Oct 17, 2021
@neverRare neverRare removed this from To do in Development Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant