Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just to say thanks #18

Closed
shalvah opened this issue Aug 7, 2018 · 1 comment
Closed

Just to say thanks #18

shalvah opened this issue Aug 7, 2018 · 1 comment

Comments

@shalvah
Copy link

shalvah commented Aug 7, 2018

Just want to say, great work with this. Was thinking I would have to implement it myself, till I stumbled on this. I'm also willing to volunteer as a maintainer if you ever need help.

Also, what do you think of getting this into the core framework? It's a terribly useful feature because for anyone using version control, managing secrets is hell (copy them out from your serverless.yml before you commit).

@colynb
Copy link
Collaborator

colynb commented May 7, 2019

I'm sorry I never said, you're welcome. :-D I'm going through and cleaning up issues finally and I just now noticed this. But you're right, when I created this I was very surprised it wasn't part of the core framework. I thought eventually they would get to it but I'm not seeing any conversations around it.

Cheers!

@colynb colynb closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants