Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to bypass dotenv-expand. #90

Closed
3 tasks
neverendingqs opened this issue Feb 6, 2021 · 0 comments · Fixed by #116
Closed
3 tasks

Add option to bypass dotenv-expand. #90

neverendingqs opened this issue Feb 6, 2021 · 0 comments · Fixed by #116
Labels

Comments

@neverendingqs
Copy link
Owner

neverendingqs commented Feb 6, 2021

If you had a dotenv file with:

456=HI
TEST_1=123$456!@#%^&*()

the final TEST_1 value will become 123HI!@#%^&*(). This is called "variable expansion", and is not always the desired behaviour.

I think I am comfortable with leaving this dotenv-expand on as default. There is no switching cost to change the default value later on, so opting to not do it at this time.

Old Description

The fact that dotenv-expand is used is not immediately obvious. Having it default to off seems to make more sense, especially with #48. This also allows us to change dotenv-expand to an optional(?) peer dependency to reduce the package size.

  • Update README to recommend new safe default
  • Update README to warn about deprecation
  • Add or update toggle to switch behaviour on major version bump
@neverendingqs neverendingqs added this to To do in v5: Safe Defaults via automation Feb 6, 2021
@neverendingqs neverendingqs changed the title Do not use dotenv-expand by default Add option to bypass dotenv-expand. Feb 10, 2021
@neverendingqs neverendingqs removed this from To do in v5: Safe Defaults Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant