Usage of Proper APIs

[aaitor]

ACN-01C: Usage of Proper APIs

Type	Severity	Location
Code Style	Informational	AccessCondition.sol:L58, L207

Description:

The DIDRegistry contract exposes the isDIDOwner function which should be favored over a manual retrieval of the DID owner and equality validation.

Example:

modifier onlyDIDOwnerOrProvider(
    bytes32 _documentId
)
{
    DIDRegistry didRegistry = DIDRegistry(
        agreementStoreManager.getDIDRegistryAddress()
    );
    
    require(
        didRegistry.isDIDProvider(_documentId, msg.sender) || 
        msg.sender == didRegistry.getDIDOwner(_documentId),
        'Invalid DID owner/provider'
    );
    _;
}

Recommendation:

We advise the linked conditionals to be replaced by the specified invocation.