Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the gateway to support new sdk changes #32

Closed
r-marques opened this issue Oct 13, 2022 · 0 comments · Fixed by #33
Closed

Modify the gateway to support new sdk changes #32

r-marques opened this issue Oct 13, 2022 · 0 comments · Fixed by #33
Assignees
@r-marques
Labels
node

Comments

@r-marques
Copy link
Member

r-marques commented Oct 13, 2022 •
edited

Update the gateway to support the new sdk currently in nevermined-io/sdk-js#379.

The main changes are related to the ServicePlugin that is now a generic ServicePlugin<Service>. This is to allow more strict control of what is returned by ServicePlugin.createService.

Create service also accepts a few additional parameters:

  • assetRewards
  • erc20TokenAddress
  • priced: boolean of whether a service is priced or not. if priced it will fill the service with the correct price data

Error can be seen here https://github.com/nevermined-io/sdk-js/actions/runs/3243518459/jobs/5318346397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-marques r-marques

Labels
node
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update versions to sdk-0.25.0 nevermined-io/node
2 participants
@mrsmkl @r-marques