Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTEs in R CMD check #1

Open
nevrome opened this issue Feb 10, 2021 · 0 comments
Open

NOTEs in R CMD check #1

nevrome opened this issue Feb 10, 2021 · 0 comments

Comments

@nevrome
Copy link
Owner

nevrome commented Feb 10, 2021

This is just a quick reminder for @nevrome why these two notes exist


> checking for GNU extensions in Makefiles ... NOTE
  GNU make is a SystemRequirements.

This exists because the voro++ Makefile uses some GNU make extensions, which should usually not be used in R packages. Without SystemRequirements: GNU make in the DESCRIPTION file we get

W  checking for GNU extensions in Makefiles
   Found the following file(s) containing GNU extensions:
     src/voro++0.4.6/Makefile
   Portable Makefiles do not use GNU extensions such as +=, :=, $(shell),
   $(wildcard), ifeq ... endif, .NOTPARALLEL See section ‘Writing portable
   packages’ in the ‘Writing R Extensions’ manual.

So this is better.

My attempt to avoid GNU extensions in the Makefile failed. No idea, which operator/function causes the WARNING.


> checking compilation flags used ... NOTE
  Compilation used the following non-portable flag(s):
    ‘-march=x86-64’

This is a local system setting independent of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant