Expose more highlighting methods #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /*! Explicitely invalidates and redraws a highlight for a specific view. */ | ||
| - (void)invalidateHighlightForView:(UIView *)view; | ||
|
|
There was a problem hiding this comment.
Ack, I'm sad these are needed :/ I'd love for these things to be automatic, but I've done a lot of thinking and haven't figured out a better way to do it.
@bogo If you have the time and energy, I'd love to see demo usage of these in one of the demo apps (or in a new demo app). That way we'd have a scaffold to build something better in the future :)
|
@bogo Added some comments but in general this is very clean and good enough for now. Let's merge this and maybe figure something cleaner out in the future :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff allows the user to request a recalculation of drop targets in case the available drop targets on the screen change during the drag. (e.g. when a table view is scrolling)
It also exposes the ability to redraw a highlight associated with the view managed by Core Dragon.
cc @nevyn