Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code bundling & optimization #14

Open
hxrts opened this issue Feb 26, 2018 · 6 comments
Open

code bundling & optimization #14

hxrts opened this issue Feb 26, 2018 · 6 comments
Assignees
Labels
core Topics specific to the core codebase. enhancement New feature or request

Comments

@hxrts
Copy link
Member

hxrts commented Feb 26, 2018

This touches on a few related topics:

  • Config files, as described in this issue, would introduce tool-specific json files which specify permissions, source assets, and other tool data. For browser extensions, such information is typically declared in the root manifest.json file, which means we can either load everything and use namespace restriction or provide functions to do so dynamically, or we can statically compile a new manifest.json.
  • Eventually we may be running several simultaneous frameworks, so we'll likely want to start integrating code optimization to deduplicate and exclude unnecessary code. The Google Closure Compiler is best in class here.
  • A compile step might eventually hook into continuous integration and packaging of the chrome extension for the app store.

At first glance, Webpack seems like the best option if we're to go in this direction, but I'd like to consider any viable alternatives before making a commitment.

@hxrts hxrts self-assigned this Feb 26, 2018
@hxrts hxrts added core Topics specific to the core codebase. enhancement New feature or request labels Feb 26, 2018
@hxrts
Copy link
Member Author

hxrts commented Feb 28, 2018

see also chrome-extension-webpack-boilerplate

@g-a-v-i-n
Copy link

starting to look into this today, looks like it will introduce some big changes to how tools are added

@hxrts
Copy link
Member Author

hxrts commented Feb 28, 2018

I'm really not wed to anything at this point. If you're up for it, I'd say give it a shot and we can adjust from there. Just getting a basic bundling step in place is a big step forward, even if it requires a fair amount of rearrangement. Feel free to delegate back to me if you'd prefer tho.

@hxrts
Copy link
Member Author

hxrts commented Apr 3, 2018

hey @gavinpatkinson did you say you had something basic going? happy to tinker with this if you'd like to focus elsewhere.

@g-a-v-i-n
Copy link

I was messing around with this boilerplate chrome-extension-webpack-boilerplate, but didn't have time to port something over from the existing toolkit like we discussed. I think the port is worth it because everything is already sort of set up and working in the boilerplate so we'd have to do much less config hell

@hxrts
Copy link
Member Author

hxrts commented Apr 5, 2018

All good. I'll give this a shot when I have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Topics specific to the core codebase. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants