Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependency on your OpenJDK role? #1

Closed
ches opened this issue Sep 14, 2014 · 3 comments
Closed

Remove hard dependency on your OpenJDK role? #1

ches opened this issue Sep 14, 2014 · 3 comments
Assignees

Comments

@ches
Copy link

ches commented Sep 14, 2014

Hiya, thanks for sharing your role!

We're using smola.java because of its great support for either OpenJDK or Oracle and choice of Java versions. We have production Java services that have been tested and shown to perform better on Oracle Java, so even though Rundeck is a utility, ideally I'd like to be able to standardize across our infrastructure and not have us pulling in a half dozen different Java roles as Ansible deps.

Would you consider removing the hard dependency, since it's so simple and there are a gillion ways to install Java? AFAIK Rundeck simply respects JAVA_HOME in its user's shell profile (or /etc/default).

Since it would be a less batteries-included experience for users of your role to have to manually add a Java role, I can understand if you'd prefer not to change it. I'm just trying to think about how Galaxy users might deal with this situation in general, it comes up regularly, with Java being a leading culprit—so I'm open to ideas. I'd much rather use your role and contribute back config file templates and such as we need them than to have a fork or vendored copy that we're lazy about because it's divergent.

Thanks for your consideration.

Also, could you bump a version on the Galaxy site please? It looks like you added the Postgres support (which needs docs 😉) and other changes since the last one. I use git SHAs like neel.rundeck,4b121be158e88 for most 3rd-party roles, but the ansible-galaxy CLI tool seems to not support that if the author has actual point versions set up on Galaxy. That system is kind of a mess in its present state, but that's another rant...

@ches
Copy link
Author

ches commented Sep 14, 2014

Ah, so actually neel.openjdk7 isn't even published to Galaxy now it seems, and ansible-galaxy install neel.rundeck doesn't seem to complain about that, so... nevermind I guess 😄

@mat-green
Copy link
Member

Fixed in v0.0.4. Thanks for the feed back.

@mat-green mat-green self-assigned this Oct 24, 2014
@mat-green
Copy link
Member

This has been done in v0.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants