Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search content type #1561

Closed
wants to merge 4 commits into from
Closed

Search content type #1561

wants to merge 4 commits into from

Conversation

jacobtoppm
Copy link
Contributor

Addresses #1530

  • Display content type even if no program is found for publication listing cards, including search
  • Find the program even for non Posts and for models linked to Program via tree structure rather than parent_programs
  • Look for story image via getattr to find story images on non Posts

However, some page types still don't have a story image, and I wasn't sure if this was something you wanted to add as part of this, so not all pages will show images in search.

… from parent_programs, but otherwise, find ancestor programs in order to accommodate pages linked to Programs via tree structure, and prevent program not being displayed in search
home/models.py Outdated Show resolved Hide resolved
home/models.py Show resolved Hide resolved
home/models.py Outdated Show resolved Hide resolved
newamericadotorg/api/search/serializers.py Show resolved Hide resolved
@nmorduch nmorduch linked an issue Sep 29, 2020 that may be closed by this pull request
3 tasks
@nmorduch
Copy link
Member

nmorduch commented Oct 1, 2020

Merged in f8afaa2 (see #1563)

@nmorduch nmorduch closed this Oct 1, 2020
@nmorduch nmorduch deleted the search-content-type branch October 2, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search] Show images and content types for all content types
3 participants