Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Subgraph input / output nodes changing position after editing subgraph #244

Closed
hthomas92 opened this issue Jan 9, 2023 · 2 comments
Labels
bug Something isn't working v2 Related to Baklava v2
Projects

Comments

@hthomas92
Copy link

The subgraph input / output nodes change position after editing an existing subgraph

Repro steps:

  1. Create a subgraph (with multiple inputs and outputs)
  2. Wire the nodes, save and go back to the main graph
  3. Edit the subgraph. After this step, all input and output nodes will be moved to the top left area in the editor and share the same position overlapping each other.
@newcat
Copy link
Owner

newcat commented Jan 14, 2023

This is (kind of) intended. As of now, I haven't implemented the necessary functionality for that. It is also not super trivial, since the input/output nodes are dynamically generated whenever the subgraph is being displayed and so they aren't saved. I'll think about a nice solution to this issue, but I admit that it doesn't have the highest priority at the moment.

@newcat newcat added v2 Related to Baklava v2 bug Something isn't working labels Jan 14, 2023
@newcat newcat added this to To do in V2 Jan 14, 2023
@hthomas92
Copy link
Author

I see... that also explains the behavior that if I wire two nodes to the same input node, then the input nodes will be duplicated after I reopen the subgraphs.

From a user's perspective, if I created a sub-graph and arranged all my nodes and wires there, including the input and output nodes, it would be nice to see the exact same layout every time I open the graph.

So I'd save the input and output nodes, and only generate them when the subgraph is created for the first time. In all other cases the user can place or delete them manually if needed.

@newcat newcat moved this from To do to Done but not released in V2 Nov 1, 2023
@newcat newcat moved this from Done but not released to Done in V2 Nov 2, 2023
@newcat newcat closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2 Related to Baklava v2
Projects
Status: Done
V2
  
Done
Development

No branches or pull requests

2 participants