Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input and output nodes cannot share the same name #39

Closed
Stumblinbear opened this issue Jul 29, 2019 · 7 comments
Closed

Input and output nodes cannot share the same name #39

Stumblinbear opened this issue Jul 29, 2019 · 7 comments
Labels
core Issues regarding the core of BaklavaJS enhancement New feature or request plugin-renderer-vue Issues regarding the Vue renderer plugin
Projects

Comments

@Stumblinbear
Copy link
Contributor

While I can sort of understand why, you use one Object for interfaces, however this seems very limiting and unnecessary.

@newcat
Copy link
Owner

newcat commented Jul 29, 2019

Yeah had separate maps/objects in earlier versions but for most use-cases it was just a hassle, so I decided to merge them into a single object. What I can do (and probably will do, but it's a breaking change, so it may take more time due to testing) is to give interfaces an additional name property, that is independent of the key in the interfaces object. This will also allow multiple input interfaces or multiple output interfaces with the same name, which might come in handy.

@newcat newcat added core Issues regarding the core of BaklavaJS enhancement New feature or request plugin-renderer-vue Issues regarding the Vue renderer plugin labels Jul 29, 2019
@Stumblinbear
Copy link
Contributor Author

I agree completely. I have a few things that benefit from expanding input/output interfaces, but having to rename them on each one makes it look a bit odd. Also, my system uses an execution flow, so the input and output nodes are named Execute. Except, of course, I can't do that, so I went with Execute and Completed except sometimes when I can't because it doesn't make sense..

@newcat newcat added this to Planned in V1.x Jul 31, 2019
@carbotaniuman
Copy link

Any updates to this? Any way I can help development on this?

@newcat
Copy link
Owner

newcat commented Sep 9, 2019

This will be the next feature I am going to work on. Should be done in the next few days, at least in the @next channel (dev branch).

@newcat
Copy link
Owner

newcat commented Sep 14, 2019

Implemented in a17cacf using the new additional property displayName. Example: https://github.com/newcat/baklavajs/blob/dev/packages/baklavajs-playground/src/MathNode.ts#L4

@newcat newcat closed this as completed Sep 14, 2019
@carbotaniuman
Copy link

@newcat So how would I do this - make the interface name nameOut and nameIn and set displayName to name?

@newcat
Copy link
Owner

newcat commented Sep 14, 2019

Correct, it should work like that.

@newcat newcat moved this from Planned to In Progress in V1.x Feb 15, 2020
@newcat newcat moved this from In Progress to Done in V1.x Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues regarding the core of BaklavaJS enhancement New feature or request plugin-renderer-vue Issues regarding the Vue renderer plugin
Projects
V1.x
  
Done
Development

No branches or pull requests

3 participants