Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/redo only partially working in the demo #397

Open
stefnotch opened this issue Mar 6, 2024 · 1 comment
Open

Undo/redo only partially working in the demo #397

stefnotch opened this issue Mar 6, 2024 · 1 comment
Labels
enhancement New feature or request
Projects

Comments

@stefnotch
Copy link

stefnotch commented Mar 6, 2024

I tried out the demo at https://codesandbox.io/s/baklavajs-v2-example-zpfkec?file=/src/App.vue , and edited the graph a little bit. I

  • renamed a node
  • changed one of the input values with the arrows
  • removed a connection
  • added an node
  • added a connection

And then I tried to undo those actions. (Ctrl+Z) However, only adding/removing nodes and connections seems to work. The values remain unchanged, and the same goes for the node names.

@newcat
Copy link
Owner

newcat commented Mar 14, 2024

Yes, this is (kind of) intentional. Unfortunately, it is very difficult to determine, whether a user action changed the value of an interface or whether it was the result of e.g. the applyResults method or any other programmatic change. In the first case, we would want to add that to the history, in the second case we don't. However, node renaming is something that should be easy to track, so I am planning to add that to the history feature.

@newcat newcat added the enhancement New feature or request label Mar 14, 2024
@newcat newcat added this to To do in V2 via automation Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
V2
  
To do
Development

No branches or pull requests

2 participants