Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min and max for NumericOptions? #42

Closed
carbotaniuman opened this issue Sep 9, 2019 · 4 comments
Closed

Min and max for NumericOptions? #42

carbotaniuman opened this issue Sep 9, 2019 · 4 comments
Assignees
@newcat
Labels
plugin-options-vue Issues regarding the Vue options plugin plugin-renderer-vue Issues regarding the Vue renderer plugin
Projects
V1.x

Comments

@carbotaniuman
Copy link

Is there an easy way to inject the min and max of a number into a custom option? I don't see such a thing being possible currently.
@newcat
Copy link
Owner

newcat commented Sep 9, 2019

You are right, this is not possible at the moment. But I am already planning to implement this, along with some other changes regarding node options.

@newcat newcat self-assigned this Sep 9, 2019
@newcat newcat added plugin-options-vue Issues regarding the Vue options plugin plugin-renderer-vue Issues regarding the Vue renderer plugin labels Sep 9, 2019
@newcat newcat added this to Planned in V1.x Sep 9, 2019
@newcat
Copy link
Owner

newcat commented Sep 14, 2019

Done with a17cacf using the additional option min and max. Example: https://github.com/newcat/baklavajs/blob/dev/packages/baklavajs-playground/src/TestNode.ts#L17

@newcat newcat closed this as completed Sep 14, 2019
@carbotaniuman
Copy link
Author

@newcat Is the same planned for IntegerOption any time soon?

@newcat
Copy link
Owner

newcat commented Sep 14, 2019

Yes, I have refactored the numeric options so IntegerOption does have min/max as well now

@newcat newcat moved this from Planned to Done in V1.x Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@newcat newcat

Labels
plugin-options-vue Issues regarding the Vue options plugin plugin-renderer-vue Issues regarding the Vue renderer plugin
Projects
V1.x
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@newcat @carbotaniuman