Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up expression parser interactions with flags #9

Closed
newmanrs opened this issue Feb 18, 2022 · 0 comments
Closed

Clean up expression parser interactions with flags #9

newmanrs opened this issue Feb 18, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@newmanrs
Copy link
Owner

The input parsing and behavior of the calculator with different arg flags in parse_expression and compute_rpn remains awkward. The function run_from_expr in the test suite, interactive and noninteractive modes call these functions slightly differently, but these should be unified. The clever hack of inserting print statements to implement verbose mode also causes kludges elsewhere when repeating last command (have to ignore prints). This could be removed just by making flags incl/ verbose part of the calculator state, and triggering on item.action() consumption.

@newmanrs newmanrs self-assigned this Feb 18, 2022
@newmanrs newmanrs added the enhancement New feature or request label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant