Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviews and give feedback #1

Closed
pachicodes opened this issue Mar 16, 2022 · 2 comments
Closed

Reviews and give feedback #1

pachicodes opened this issue Mar 16, 2022 · 2 comments
Assignees
@hummusonrails

Comments

@pachicodes
Copy link
Contributor

Hello ben, when you have some time can you review this repo and give me some feedback on it?
There are some fields note filled because I am not sure what is the right thing to use there, so all the help you can give is welcomed!

Thank you!
@hummusonrails
Copy link
Contributor

@pachicodes - It looks great! I added a PR for you to review, and if it looks good, to merge, that fixes some small typos.

You also need to add an example of the newrelic.js file in the repository, and show how you can use dotenv variables to safely use your New Relic License Key, i.e. process.env.NEW_RELIC_LICENSE_KEY.

@pachicodes
Copy link
Contributor Author

Thank you @bencgreenberg !
I believe I had added the example you mentioned correctly, but just to be safe can you review it when you have time?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hummusonrails hummusonrails

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hummusonrails @pachicodes