Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd Party SDK component function deprecation Plan #1033

Closed
11 tasks done
jpvajda opened this issue Dec 15, 2020 · 7 comments · Fixed by #1070
Closed
11 tasks done

3rd Party SDK component function deprecation Plan #1033

jpvajda opened this issue Dec 15, 2020 · 7 comments · Fixed by #1070
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jpvajda
Copy link
Contributor

jpvajda commented Dec 15, 2020

on December 31st 2020 February 28th 2021 the following will be deprecated:

currently marked as deprecated on dec 31

currently the example shows the new way it's done, but the props section shows the old deprecated way

currently marked as deprecated on dec 31

already set as required

component makes no mention of this being expired on Dec 31

component makes no mention of this being expired on Dec 31

The plan

All deprecations follow a 1-year process that involves console logging for the first 11 months (first as log, followed by warn, followed by error), and for the last month a red toast with the "Deprecation" title and the message below, in case you never opened the console. Documentation also get an deprecated tag explaining the reasoning behind it.

We can also do a internal post on Nerdlife and a Discuss post as well as updating the developer site for 3rd party developers with the changes. We can coordinate pulling in the function and prop  updates from a 3rd party bundle.

AC

  • consider how these changes will impact the dev site and put a plan in place to address it.
  • determine how we'll update the core components from the SDK bundle.
  • ask Miguel to pull global app owners from artifact registry.
  • Work with @tangollama to find a way to automate this GH Issue using Replinter.
  • post nerdlife post about these changes.
  • post discuss post about these changes.
  • Share post with #wizard programmablity slack channel
  • Setup Office hours for Field Sales Teams to get questions answered
  • Notify all Field Sales leaders of this change via email
  • update any guides that may be using deprecated functionality.
  • Integrate with a proper 3rd party bundle that can keep our site up to date with the core changes. GH Issue

Possible Guide updates

https://developer.newrelic.com/build-apps/add-nerdgraphquery-guide

This guide mentions account selection in step 2.

https://developer.newrelic.com/build-apps/howto-use-nrone-table-components

this guide uses TableRow Actions with iconType in step 8

@jpvajda jpvajda created this issue from a note in DevEn Community Content Contributions (Proposed) Dec 15, 2020
@jpvajda jpvajda moved this from Proposed to To Do in DevEn Community Content Contributions Dec 15, 2020
@jpvajda jpvajda self-assigned this Dec 15, 2020
@jpvajda jpvajda added the documentation Improvements or additions to documentation label Dec 15, 2020
@jpvajda jpvajda moved this from To Do to In progress in DevEn Community Content Contributions Dec 15, 2020
@jpvajda
Copy link
Contributor Author

jpvajda commented Dec 15, 2020

I've reached out @mjesun about obtaining an update SDK bundle for the component changes so we can import that into the Dev Site. All guides can be updated when the official changes are in place.

@jpvajda
Copy link
Contributor Author

jpvajda commented Dec 16, 2020

@alexronquillo just an FYI on this change...

@jpvajda
Copy link
Contributor Author

jpvajda commented Dec 18, 2020

confirmed these actually will be deprecated on Feb 28th, not Dec 31st

@jpvajda
Copy link
Contributor Author

jpvajda commented Jan 8, 2021

#895

@jpvajda
Copy link
Contributor Author

jpvajda commented Jan 27, 2021

Dev Site updated with new components: #1070

@jpvajda jpvajda linked a pull request Jan 27, 2021 that will close this issue
@jpvajda
Copy link
Contributor Author

jpvajda commented Jan 27, 2021

all guides look good, components are updated on the dev site as well.

@jpvajda
Copy link
Contributor Author

jpvajda commented Feb 3, 2021

Marking this issue as done as all work is being track on this project board for 3rd party apps. https://github.com/orgs/newrelic/projects/44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging a pull request may close this issue.

4 participants