Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Right Rail] Component with GitHub buttons #191

Closed
5 of 6 tasks
zstix opened this issue Oct 29, 2020 · 3 comments · Fixed by #208
Closed
5 of 6 tasks

[Right Rail] Component with GitHub buttons #191

zstix opened this issue Oct 29, 2020 · 3 comments · Fixed by #208
Assignees
Labels
enhancement New feature or request

Comments

@zstix
Copy link
Contributor

zstix commented Oct 29, 2020

Description

The docs site will have a "right rail" component that will show a few page-specific items.

The component will look similar to the right rail that appears on the developer site, so we will want to consider abstracting it to the theme. If we decide to do this, we will want the ability to toggle the "Page last modified" message and some other customization options.

NOTE: This tickets is just for making the component in the theme with the Create an issue and Edit this page buttons.
Adding the in-page navigation is tracked in another ticket: #192

NOTE: Mobile responsiveness is tracked in another ticket: #193

Acceptance Criteria

  • Generalized right-rail component added to the Gatsby theme
  • Right rail component re-added to the dev site
  • Right rail component added to docs site pages
  • GitHub buttons link to the correct locations
  • Ability to set "last modified" as a prop
  • Ability to set contributing guide (default to CONTRIBUTING.md)

Screenshot(s)

Right Rail on Developer Site:
Screen Shot 2020-10-29 at 4 02 30 PM

Wireframes for Docs Site:
Screen Shot 2020-10-29 at 4 03 24 PM

@zstix
Copy link
Contributor Author

zstix commented Oct 30, 2020

Move this to the theme repository.

@jerelmiller
Copy link
Contributor

Created an issue in the theme repo for this as well: newrelic/gatsby-theme-newrelic#144

@jerelmiller
Copy link
Contributor

This issue can now focus on only the docs work needed to integrate with the component.

@jerelmiller jerelmiller moved this from In progress to In review in Developer Enablement Team Oct 31, 2020
@jerelmiller jerelmiller moved this from In review to In progress in Developer Enablement Team Oct 31, 2020
@zstix zstix moved this from In progress to In review in Developer Enablement Team Oct 31, 2020
Developer Enablement Team automation moved this from In review to Done Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants