Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API documentation for source maps re: YOUR_NEW_RELIC_APP_ID #2028

Closed
CherylFrankenfield opened this issue Apr 27, 2021 · 2 comments · Fixed by #8046
Closed

Update API documentation for source maps re: YOUR_NEW_RELIC_APP_ID #2028

CherylFrankenfield opened this issue Apr 27, 2021 · 2 comments · Fixed by #8046
Labels
content requests related to docs site content docs-issues from_internal Identifies issues/PRs from Relics (except writers)

Comments

@CherylFrankenfield
Copy link
Contributor

Tell us what you need

  • Update API documentation to correctly describe what app IDs are needed as it is currently a mix and may be confusing.
  • YOUR_NEW_RELIC_APP_ID is used in examples using API via curl, though npm examples include: applicationId: YOUR_NEW_RELIC_APP_ID, and NPM package directions here: https://www.npmjs.com/package/@newrelic/publish-sourcemap reference: --applicationId Browser application id (APPLICATION_ID)

Anything else you'd like to share?

Guidance is to use the application ID from the copy-paste snippet in application settings which is the APM app ID if it exists, Browser app ID otherwise, though it is not explicitly stated in our docs.

Doc information (don't delete this section)

@github-actions github-actions bot added this to Needs Triage in Docs PRs and Issues Apr 27, 2021
@CherylFrankenfield
Copy link
Contributor Author

@urbiz-nr urbiz-nr moved this from Needs Triage to Hero: To do in Docs PRs and Issues Apr 28, 2021
@bradleycamacho bradleycamacho moved this from Hero: To do to In review (Hero or any TW) in Docs PRs and Issues Apr 28, 2021
@bradleycamacho bradleycamacho self-assigned this Apr 28, 2021
@bradleycamacho bradleycamacho added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Apr 28, 2021
@bradleycamacho bradleycamacho moved this from In review (Hero or any TW) to Waiting on SME/Blocked in Docs PRs and Issues May 3, 2021
@bradleycamacho bradleycamacho removed their assignment Sep 16, 2021
@CherylFrankenfield
Copy link
Contributor Author

Due to a deployment yesterday, users should be able to use both app Ids for source map files now. This issue can be archived, though we could clarify in docs that both can be used. Thank you again!

Please see thread here with engineering:
https://newrelic.slack.com/archives/C28SEP2LR/p1644278215278689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content docs-issues from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Waiting on SME/Blocked
Development

Successfully merging a pull request may close this issue.

2 participants