🐛 Dashboard Sanitization script is improperly changing certain patterns

[thezackm]

Description

Using the dashboard validation script during local development (npm --prefix validator run sanitize-dashboards) is creating broken widgets on a specific query pattern seen in both the existing kentik_default dashboard and the new dashboard being added in PR #468

Steps to Reproduce

Clone the repo locally and run the dashboard validation script. No changes should be necessary as the current dashboard for Kentik Default entities is in "violation" and should show the problem.

Expected Behavior

This pattern should be ignored by the validation script since it's a valid dashboard definition and NRQL syntax before being adjusted.

Relevant Logs / Console output

This is only happening on the following pattern:

"FROM Metric SELECT round(latest(kentik.snmp.hrStorageUsed)*100/latest(kentik.snmp.hrStorageSize), .01) AS 'Used %', round(latest(kentik.snmp.hrStorageSize)*1e-6,.01) AS 'Total (MB)', round(latest(kentik.snmp.hrStorageUsed)*1e-6,.01) AS 'Used (MB)' WHERE provider = 'kentik-poweriq' FACET storage_description LIMIT MAX"

Specifically; this portion of the string:

(kentik.snmp.hrStorageSize), .01)

Which is being improperly sanitized to this: (replacing ) with } and removing ,)

(kentik.snmp.hrStorageSize} .01)

Additional context

This is negatively impacting each time a PR is run and the sanitization script is executed locally as it puts these dashboards at risk of a breaking change in production with a bad NRQL syntax on these widgets.

[naxhh]

We created an internal task to track this ticket EIS-634

[andre-nr]

Hi @thezackm,
a fix for this issue has been deployed.