Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jackc/pgx as a postgres driver #142

Closed
dankinder opened this issue May 6, 2020 · 15 comments · Fixed by #374
Closed

Support jackc/pgx as a postgres driver #142

dankinder opened this issue May 6, 2020 · 15 comments · Fixed by #374
Assignees
Labels
epic MMF p1 Highest priority work items

Comments

@dankinder
Copy link

dankinder commented May 6, 2020

We've been using lib/pq for quite a while, so the existing nrpq has satisfied us so far, but there are 2 issues with it.
One is that the bottom of https://github.com/lib/pq indicates that it is in maintenance mode and won't get new features. It says to use https://github.com/jackc/pgx instead.
The other is the immediate need we have now: lib/pq doesn't have any intelligent retry logic, whereas pgx does retry queries on certain safe kinds of errors. We are finding that we need this, e.g. to handle broken pipes.
Can you guys provide a package that supports jackc/pgx?

@newrelic-eheinlein
Copy link
Contributor

Hi @dankinder - thank you very much for this feedback! I am going to loop in our product manager for the Go Agent; she can take a look whether we can get this on our roadmap and how it can be prioritized.

If anyone else comes across this issue and is also looking for support for jackc/pgx, please feel free to chime in and let us know!

@jodeev
Copy link
Contributor

jodeev commented May 29, 2020

I'm closing this issue for now. I've made sure to put this in our backlog, and I expect that we will get to this in an upcoming bugfix/cleanup.

We would definitely like to know how many others also need this, so please add a comment if you are also interested.

@jodeev jodeev closed this as completed May 29, 2020
@etokarev
Copy link

We are also interested in supporting jackc/pgx by nrpq

@newrelic-eheinlein
Copy link
Contributor

@etokarev Thanks for adding your voice! We will take note in the ticket in our backlog.

@etokarev
Copy link

etokarev commented Jul 1, 2020

@newrelic-eheinlein would it possible to provide some ETA on adding support for jackc/pgx? We need to add NR instrumentation to db calls in our applications and we are currently blocked because our apps use pgx driver.
Having a rough ETA will help us to decide if we want to wait for NR Agent to support it or consider with other options like switching to pq, writing our own instrumentation wrapper , etc

@purple4reina
Copy link
Contributor

Hey @etokarev, We don't have a definitive timeline just yet on when we'll be able to get to this work. In the meantime, you can always manually create DatastoreSegments using the API. Check out the detailed explanation in the Guide.

@jodeev jodeev assigned jodeev and unassigned jodeev Jul 13, 2020
@jodeev jodeev reopened this Jul 13, 2020
@jodeev jodeev self-assigned this Jul 13, 2020
@jodeev jodeev added this to To Do in Go Engineering Board Mar 18, 2021
@jodeev jodeev added the epic MMF label Mar 18, 2021
@jodeev jodeev added this to Future possible work in Roadmap Mar 18, 2021
@jodeev jodeev moved this from To Do to Backlog in Go Engineering Board Mar 18, 2021
@penguinxr2
Copy link

interested in this as well, thanks!

@jameshalsall
Copy link

This would be great 👍🏻

@wedow
Copy link

wedow commented Jun 23, 2021

Would also really appreciate this

@jbarton123
Copy link

Interested and would really appreciate as well! Thanks!

@ghmj2417
Copy link

Interested

@ak-war
Copy link

ak-war commented Jul 13, 2021

Thank you for your valuable feedback, we welcome your ideas and it definitely helps us make crucial decisions regarding how we can best fulfill your needs. This work item is coming up on our roadmap and is being targeted for completion around the end of August.

@ak-war ak-war added the p1 Highest priority work items label Jul 20, 2021
@yulrizka
Copy link

yulrizka commented Jul 30, 2021

I played around and porting the lib/pq. It seems to be working.
https://github.com/yulrizka/nrpgx

Let me know if you open for a PR.

Since there's already an official release, I deleted this fork

@RichVanderwal
Copy link
Contributor

Hi @yulrizka , we'd love to look at your PR! Even if we don't use it directly, it will certainly inform our upcoming support.

@nr-swilloughby
Copy link
Contributor

We have an official integration for using pgx on its way, so stay tuned. It addresses the same use case as our nrpq integration, namely using the standard library database/sql with the pgx driver. Supporting pgx's direct (non-database/sql) mode of operation is a separate matter we'll consider based on demand for having that as well.

Go Engineering Board automation moved this from Backlog to Done Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic MMF p1 Highest priority work items
Projects
Roadmap
Future possible work
Development

Successfully merging a pull request may close this issue.