Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nri-metadata-injection] Add Pod Disruption Budget when deploying more than one replica #104

Closed
mitchellmaler opened this issue Aug 4, 2020 · 2 comments
Closed

[nri-metadata-injection] Add Pod Disruption Budget when deploying more than one replica #104

mitchellmaler opened this issue Aug 4, 2020 · 2 comments
Labels
triage/pending Issue or PR is pending for triage and prioritization.

Comments

@mitchellmaler
Copy link

Is your feature request related to a problem? Please describe.

Currently the deployment does not come with a pod disruption budget.

Describe the solution you'd like

Add a pod disruption budget when deploying more than one replica to make sure at least one is always running.
@tyrken
Copy link

tyrken commented Jul 9, 2021

As a system webhook this really should have replicas default to more than 1 and a PDB as you suggest. Glad to see there's already an affinity option, at least.

@paologallinaharbur paologallinaharbur added priority/pending triage/pending Issue or PR is pending for triage and prioritization. and removed priority/pending labels Jul 30, 2021
@kang-makes kang-makes mentioned this issue May 6, 2022
Closed
@kang-makes
Copy link
Contributor

kang-makes commented May 6, 2022 •
edited
Loading

Issue moved to newrelic/k8s-metadata-injection#173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage/pending Issue or PR is pending for triage and prioritization.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tyrken @mitchellmaler @paologallinaharbur @kang-makes