Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nri-kube-events] Duplicate imagePullPolicy #407

Closed
DWSR opened this issue Jun 15, 2021 · 0 comments · Fixed by #415
Closed

[nri-kube-events] Duplicate imagePullPolicy #407

DWSR opened this issue Jun 15, 2021 · 0 comments · Fixed by #415

Comments

@DWSR
Copy link

DWSR commented Jun 15, 2021

Bug description

imagePullPolicy is defined twice in one of the container definitions:

imagePullPolicy: {{ .Values.image.kubeEvents.pullPolicy }}
securityContext:
privileged: false
allowPrivilegeEscalation: false
readOnlyRootFilesystem: true
{{- if .Values.resources }}
resources:
{{ toYaml .Values.resources | indent 12 }}
{{- end }}
imagePullPolicy: IfNotPresent

Version of Helm and Kubernetes

Helm: Any version
Kubernetes: Doesn't matter

Which chart?

nri-kube-events 1.9.2

What happened?

Ran helm template and got back invalid YAML.

What you expected to happen?

Running helm template should produce valid YAML

How to reproduce it?

Using the following values.yaml:

kubeEvents:
  enabled: true

global:
  customSecretName: "newrelic-api-keys"
  customSecretLicenseKey: "license-key"
  customSecretInsightsKey: "insights-key"
  cluster: "CLUSTER_NAME"

Run helm template newrelic newrelic/nri-bundle --values values.yaml

Anything else we need to know?

I would love Kustomize applications instead of Helm charts for exactly reasons like this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant