Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The agent reports docker process samples when enable_process_metrics: false #167

Closed
cristianciutea opened this issue Oct 13, 2020 · 2 comments · Fixed by #205
Closed

The agent reports docker process samples when enable_process_metrics: false #167

cristianciutea opened this issue Oct 13, 2020 · 2 comments · Fixed by #205
Assignees
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@cristianciutea
Copy link
Contributor

cristianciutea commented Oct 13, 2020

Description

We have noticed that on new default behavior of filtered process samples, the process samples for docker are still reported.

To reproduce install an agent to monitor an environment with docker(add at least one container) and disable process metrics:
enable_process_metrics: false

@cristianciutea cristianciutea added the bug Categorizes issue or PR as related to a bug. label Oct 13, 2020
@josemore
Copy link
Contributor

Note you should still be able to disable process samples when running on docker using the metrics_process_sample_rate: -1 setting in the infra-agent.

@josemore josemore added this to Ready for Development in CAOS: Our Daily Bread Nov 2, 2020
@noly noly moved this from Ready for Development to In Progress in CAOS: Our Daily Bread Nov 3, 2020
@noly noly moved this from In Progress to Ready for review in CAOS: Our Daily Bread Nov 3, 2020
@noly noly moved this from Ready for review to In Progress in CAOS: Our Daily Bread Nov 3, 2020
@noly noly moved this from In Progress to Ready for review in CAOS: Our Daily Bread Nov 3, 2020
@noly noly moved this from Ready for review to Ready For Release in CAOS: Our Daily Bread Nov 3, 2020
@josemore
Copy link
Contributor

josemore commented Nov 4, 2020

We also noticed that the "include_matching_metrics" setting was not being applied against docker processes when running the containerized agent.
The linked fix aims to solve both scenarios: enable_process_metrics and include_matching_metrics.

@noly noly moved this from Ready For Release to Done in CAOS: Our Daily Bread Nov 9, 2020
@noly noly removed the pre-release label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
No open projects
4 participants