Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Summary needs delta calculation on "sum" metric #188

Closed
ardias opened this issue Oct 26, 2020 · 1 comment · Fixed by #191
Closed

Prometheus Summary needs delta calculation on "sum" metric #188

ardias opened this issue Oct 26, 2020 · 1 comment · Fixed by #191
Assignees
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@ardias
Copy link
Contributor

ardias commented Oct 26, 2020

According to the slack threads below, the "sum" component of the summary metric needs to be "delta calculated" in order for NRQL to be able to calculate averages on Prometheus summary values.

https://newrelic.slack.com/archives/CME11J4PL/p1602875630066900
https://newrelic.slack.com/archives/CP2EWSX7C/p1603384162298100

Summary must be handled like Histogram: calculate delta on "sum" and only send value if we can in fact calculate it, i.e., it's not the first value we received.

See this PR for the implementeation on the telemetry sdk emitter: newrelic/nri-prometheus#101

@ardias ardias added the bug Categorizes issue or PR as related to a bug. label Oct 26, 2020
@noly noly self-assigned this Oct 26, 2020
@noly
Copy link
Contributor

noly commented Oct 26, 2020

Thank for your feedback @ardias, I will start to work on this now.

I will let you know when is solved.

@noly noly added this to In Progress in CAOS: Our Daily Bread Oct 26, 2020
@noly noly moved this from In Progress to Ready for review in CAOS: Our Daily Bread Oct 28, 2020
@noly noly closed this as completed in #191 Oct 28, 2020
@brushknight brushknight moved this from Ready for review to Ready For Release in CAOS: Our Daily Bread Oct 29, 2020
@noly noly moved this from Ready For Release to Done in CAOS: Our Daily Bread Nov 10, 2020
@noly noly removed the pre-release label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants