Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send value instead of memory address for pointer config options #647

Closed
rubenruizdegauna opened this issue Jul 16, 2021 · 0 comments · Fixed by #662
Closed

Send value instead of memory address for pointer config options #647

rubenruizdegauna opened this issue Jul 16, 2021 · 0 comments · Fixed by #662
Assignees
@varas
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@rubenruizdegauna
Copy link
Contributor

For config options that are pointers the agent should send the value instead of the memory address.
i.e. enable_process_metrics is being sent wrongly.

// EnableProcessMetrics enables/disables process metrics, it does not enforce when not set.
// Default: empty
// Public: Yes
EnableProcessMetrics *bool `yaml:"enable_process_metrics" envconfig:"enable_process_metrics"`

Related: GTSE-9894
@rubenruizdegauna rubenruizdegauna added the bug Categorizes issue or PR as related to a bug. label Jul 16, 2021
@varas varas self-assigned this Jul 29, 2021
@varas varas linked a pull request Jul 29, 2021 that will close this issue
Config.PublicFields dereference pointers #662
Merged
@varas varas mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varas varas

Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Config.PublicFields dereference pointers newrelic/infrastructure-agent
2 participants
@varas @rubenruizdegauna