Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in "dicitonary" #24

Open
danielgolden opened this issue Mar 15, 2022 · 6 comments · May be fixed by #26
Open

Fix typo in "dicitonary" #24

danielgolden opened this issue Mar 15, 2022 · 6 comments · May be fixed by #26
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@danielgolden
Copy link
Contributor

image (1)

@danielgolden danielgolden added bug Something isn't working good first issue Good for newcomers labels Mar 15, 2022
@Dun-sin
Copy link

Dun-sin commented Aug 8, 2022

hi, can i work on this?

@danielgolden
Copy link
Contributor Author

@Dun-sin yeah, a PR for this would be great! Thanks :)

@Dun-sin
Copy link

Dun-sin commented Aug 9, 2022

I looked into this and saw that it's coming from the library used here, so unless it's fixed in the library and updated into this app, there's nothing to be done

Seems like it also belongs to you, I will make the pull request here

https://github.com/danielgolden/language-linter.git

@danielgolden
Copy link
Contributor Author

True story. That would be great. Thank you!

@danielgolden
Copy link
Contributor Author

Just merged your PR (thanks again :)) and published a new version of the package containing the fix. I'm on vacation right now and my connection isn't great so I'm having trouble updating this repo to use the updated version but I should be able to update it once I get back to a decent connection.

If updating this repo to use the new version (1.2.41) of the new-relic-language-linter npm package is something you'd like to do yourself. Feel free to open a PR for it.

@Dun-sin
Copy link

Dun-sin commented Aug 9, 2022

Just merged your PR (thanks again :)) and published a new version of the package containing the fix. I'm on vacation right now and my connection isn't great so I'm having trouble updating this repo to use the updated version but I should be able to update it once I get back to a decent connection.

If updating this repo to use the new version (1.2.41) of the new-relic-language-linter npm package is something you'd like to do yourself. Feel free to open a PR for it.

Alright let me help so you can enjoy your vacation🤝🏽

@Dun-sin Dun-sin linked a pull request Aug 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants