Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for error stack traces in old opera versions #71

Closed
rr0214 opened this issue Jun 4, 2021 · 1 comment · Fixed by #103
Closed

Remove support for error stack traces in old opera versions #71

rr0214 opened this issue Jun 4, 2021 · 1 comment · Fixed by #103
Assignees
@metal-messiah
Labels
enhancement New feature or request
Projects
Browser Instrumentation Engineering B...

Comments

@rr0214
Copy link

rr0214 commented Jun 4, 2021

Opera is no

If time ever comes up to work on JS Errors or removal of legacy code, there are some comments not suitable for public GitHub that identify a portion of the stack trace parsing code built exclusively to support old Opera versions. The work would involve not parsing stack traces for versions of Opera older than 9 and allow us to delete old code.

See comments in this commit: https://source.datanerd.us/browser/browser_agent/blob/903edda05371cd7b253668fd73a680a009cc6acc/feature/err/aggregate/compute-stack-trace.js#L264-L266

https://source.datanerd.us/browser/browser_agent/blob/903edda05371cd7b253668fd73a680a009cc6acc/feature/err/aggregate/compute-stack-trace.js#L322-L327
@rr0214 rr0214 added enhancement New feature or request needs triage labels Jun 4, 2021
@coreyarnold coreyarnold added this to Triage Needed: Unprioritized Features in Browser Instrumentation Engineering Board Jun 11, 2021
@rr0214
Copy link
Author

rr0214 commented Aug 24, 2021 •
edited
Loading

Needs investigation. Discuss how to implement supportability metrics in agent.

@rr0214 rr0214 moved this from Triage Needed: Unprioritized Features to To do: Features here are prioritized in Browser Instrumentation Engineering Board Aug 24, 2021
@martinkuba martinkuba mentioned this issue Aug 24, 2021
Closed
@metal-messiah metal-messiah moved this from To do: Features here are prioritized to In progress: Issues being worked on in Browser Instrumentation Engineering Board Sep 1, 2021
@metal-messiah metal-messiah self-assigned this Sep 1, 2021
@metal-messiah metal-messiah mentioned this issue Sep 2, 2021
Merged
@metal-messiah metal-messiah linked a pull request Sep 2, 2021 that will close this issue
Remove all references of Opera [Now Flagged as Not Supported] #103
Merged
@metal-messiah metal-messiah moved this from In progress: Issues being worked on to Needs PR Review in Browser Instrumentation Engineering Board Sep 2, 2021
Browser Instrumentation Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metal-messiah metal-messiah

Labels
enhancement New feature or request
Projects
Browser Instrumentation Engineering B...
  
Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all references of Opera [Now Flagged as Not Supported] metal-messiah/newrelic-browser-agent
2 participants
@rr0214 @metal-messiah