Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the 32bit experience when installing the 64bit agent. #1890

Merged
merged 2 commits into from Sep 7, 2023

Conversation

jaffinito
Copy link
Member

Description

  • Adds an action that will look for an existing install of the agent, capture its bitness and compare it to the installer's bitness. IF they are different the installer throws an error message and forces an exit.
  • The 64 bit installer now sets the COR_PROFILER_PATH_32 and CORECLR_PROFILER_PATH_32 env vars in the registry for WAS and W3SVC pointing to the already installed 32bit profiler. This will allow 32bit apps to get instrumented.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

feat: Prevent using different bitness installer when in-place upgrading.
feat: Add 32bit profiler path to IIS registry when installing 64bit agent.
@codecov-commenter
Copy link

Codecov Report

Merging #1890 (e8087c5) into main (737b4f1) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1890   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files         402      402           
  Lines       24670    24670           
=======================================
+ Hits        20597    20598    +1     
+ Misses       4073     4072    -1     

see 5 files with indirect coverage changes

@jaffinito jaffinito merged commit 65dd50b into main Sep 7, 2023
71 checks passed
@jaffinito jaffinito deleted the feature/improve-32-64-bit-xp branch September 7, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate IIS Registry Key Values When Installing x86 and x64 MSI
4 participants