feat: Enable startup logging to Event Log for all applications on Windows. #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
nrcventura
reviewed
Oct 11, 2023
chynesNR
approved these changes
Oct 12, 2023
nrcventura
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables configuration of the Event Log sink for Serilog during Agent startup when running on Windows in both .NET Framework and .NET 6+ applications.
Note that the Event Log sink will only write to the event log if the
New Relic .NET AgentEvent Source already exists or if the application is running with administrator privileges.This change supersedes a previous commit (#4310e982) that was reverted.