Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce exception logging on CallVendorApi failures. #2006

Merged
merged 1 commit into from Oct 24, 2023
Merged

fix: Reduce exception logging on CallVendorApi failures. #2006

merged 1 commit into from Oct 24, 2023

Conversation

tippmar-nr
Copy link
Member

Description

Reduces exception logging during CallVendorApi() failures.

2023-10-24 16:15:55,194 NewRelic  DEBUG: [pid: 6824, tid: 8] CallVendorApi (aws) failed: A socket operation was attempted to an unreachable network. [::ffff:169.254.169.254]:80 (169.254.169.254:80)
2023-10-24 16:15:55,350 NewRelic  DEBUG: [pid: 6824, tid: 8] CallVendorApi (azure) failed: A socket operation was attempted to an unreachable network. [::ffff:169.254.169.254]:80 (169.254.169.254:80)
2023-10-24 16:15:55,532 NewRelic  DEBUG: [pid: 6824, tid: 8] CallVendorApi (gcp) failed: No such host is known. (metadata.google.internal:80)

Resolves #2005

@tippmar-nr tippmar-nr requested a review from a team as a code owner October 24, 2023 16:20
@tippmar-nr tippmar-nr enabled auto-merge (squash) October 24, 2023 16:29
@tippmar-nr tippmar-nr enabled auto-merge (squash) October 24, 2023 16:29
nr-ahemsath
nr-ahemsath approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this. 👍

@tippmar-nr tippmar-nr merged commit bf4102b into main Oct 24, 2023
76 checks passed
@tippmar-nr tippmar-nr deleted the chore/callvendorapi-logging branch October 24, 2023 17:27
@dotnet-agent-team-bot dotnet-agent-team-bot mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrcventura nrcventura nrcventura approved these changes

@nr-ahemsath nr-ahemsath nr-ahemsath approved these changes

@jaffinito jaffinito Awaiting requested review from jaffinito jaffinito is a code owner automatically assigned from newrelic/dotnet-code-reviewers

@chynesNR chynesNR Awaiting requested review from chynesNR chynesNR is a code owner automatically assigned from newrelic/dotnet-code-reviewers

@dotnet-agent-team-bot dotnet-agent-team-bot Awaiting requested review from dotnet-agent-team-bot dotnet-agent-team-bot is a code owner automatically assigned from newrelic/dotnet-code-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce logging for CallVendorApi exceptions
3 participants
@tippmar-nr @nrcventura @nr-ahemsath