Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When audit logging is enabled, no logs are written to the audit log file. #2029

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

tippmar-nr
Copy link
Member

Fixes an issue where audit logging wasn't correctly enabled at runtime.

Resolves #2028

@codecov-commenter
Copy link

Codecov Report

Merging #2029 (73bb145) into main (2693125) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2029      +/-   ##
==========================================
+ Coverage   80.31%   80.34%   +0.02%     
==========================================
  Files         404      404              
  Lines       24903    24902       -1     
  Branches     3003     3003              
==========================================
+ Hits        20002    20008       +6     
+ Misses       4116     4113       -3     
+ Partials      785      781       -4     
Files Coverage Δ
src/Agent/NewRelic/Agent/Core/Logging/AuditLog.cs 83.33% <ø> (-16.67%) ⬇️
.../NewRelic/Agent/Core/Logging/LoggerBootstrapper.cs 78.75% <100.00%> (+0.13%) ⬆️

... and 3 files with indirect coverage changes

@tippmar-nr tippmar-nr merged commit c6b940d into main Nov 6, 2023
77 checks passed
@tippmar-nr tippmar-nr deleted the fix/audit-log-broken branch November 6, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit logging does not get enabled correctly
4 participants