Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Defensive coding and exception handling during ASP.NET Core 6+ browser injection #2038

Merged
merged 2 commits into from Nov 8, 2023

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Nov 8, 2023

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Adds more defensive coding and exception handling during ASP.NET Core 6+ browser agent injection. Also adds an integration test to validate that we're handling responses that don't set a ContentType header.

Resolves #2035

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

Merging #2038 (a5da07f) into main (ca96d0c) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 75.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2038      +/-   ##
==========================================
- Coverage   81.07%   81.05%   -0.03%     
==========================================
  Files         394      394              
  Lines       24667    24672       +5     
  Branches     2962     2962              
==========================================
- Hits        20000    19998       -2     
- Misses       3883     3889       +6     
- Partials      784      785       +1     
Files Coverage Δ
...serMonitoring/BrowserScriptInjectionIndexHelper.cs 82.25% <75.86%> (-5.47%) ⬇️

... and 4 files with indirect coverage changes

@tippmar-nr tippmar-nr enabled auto-merge (squash) November 8, 2023 22:08
@tippmar-nr tippmar-nr merged commit 5ddd0ea into main Nov 8, 2023
76 of 77 checks passed
@tippmar-nr tippmar-nr deleted the fix/aspnetcore-browser-injection-bug-fix branch November 8, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null Reference Exception when upgrading from 10.18 to 10.19
5 participants