Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to less restrictive Container ID check if not found #2256

Closed
chynesNR opened this issue Feb 20, 2024 · 1 comment · Fixed by #2263
Closed

Fall back to less restrictive Container ID check if not found #2256

chynesNR opened this issue Feb 20, 2024 · 1 comment · Fixed by #2263
Labels
bug Something isn't working

Comments

@chynesNR
Copy link
Member

As part of this PR we changed how we pull the the Container ID from cgroups in order to support cgroup v2 and to cut down on false positives. We have a customer where the old Agent (10.17 and below) works for them, but 10.18 and above does not.

We should have a fallback mechanism where if we can't find the Container ID with the existing regex, we should fall back to the "any 64 character alphanumeric string" regex. However, it's important that we only do this for cgroup v1. Attempting to parse mountinfo this way will result in false positives.

For Maintainers Only or Hero Triaging this bug
Suggested T-Shirt size (S, M, L, XL, Unknown): S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant