Fix issue #2261 #2315
Merged
Fix issue #2261 #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowell-trimble
requested review from
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR,
tippmar-nr and
dotnet-agent-team-bot
|
|
|
@lowell-trimble Thank you for submitting this PR. The link to the LoggerFactory source that you shared was helpful in explaining the solution (so that we do not need to walk the list to find the first item with an external provider). I think that the existing integration tests should be sufficient for this PR and I am running them locally to confirm that everything is still working as expected. |
nrcventura
approved these changes
Mar 8, 2024
chynesNR
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: Fix a context data capture when the Microsoft.Extensions.Logging console logger is used (thanks @lowell-trimble!) (#2261) (#2315)
END_COMMIT_OVERRIDE
Description
Fixing issue #2261. When there are multiple logging providers registered, only the last provider will have the ExternalScopeProvider set to a non-null value. Because of this, new relic's logic to pull the first ScopeLogger from the array causes context data to be missed. The simple fix is to simply grab the last value in the array.
Author Checklist
Reviewer Checklist