fix: Handle InvalidOperationException in StringsHelper.CleanUri() #2373 #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
nrcventura
approved these changes
Mar 26, 2024
chynesNR
reviewed
Mar 26, 2024
chynesNR
approved these changes
Mar 26, 2024
jaffinito
reviewed
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds handling for
InvalidOperationExceptionthat can be thrown in certain cases (.NET 6 and later) when callingUri.GetComponents().Updates unit tests for the Parsing project to target .NET 8 in addition to .NET Framework 4.6.2. Had to make a number of tests run only in .NET Framework due to references to Framework-specific types.
Fixes #2373.
Author Checklist
Reviewer Checklist