-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for capturing container id from AWS ECS. #2481
Conversation
… feature/fargate-docker-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2481 +/- ##
=======================================
Coverage 80.55% 80.56%
=======================================
Files 459 459
Lines 28759 28802 +43
Branches 3152 3159 +7
=======================================
+ Hits 23168 23203 +35
- Misses 4812 4817 +5
- Partials 779 782 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. 👍
On hold while we wait for more details about the missing linkage with infra.
Description
Notes:
Once/If this is approved, I will update the agent specs with our implementation.
Author Checklist
Reviewer Checklist