fix: Agent license key should be optional in Serverless mode. #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
chynesNR
approved these changes
May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2500 +/- ##
==========================================
- Coverage 80.60% 80.57% -0.03%
==========================================
Files 459 459
Lines 28774 28774
Branches 3184 3183 -1
==========================================
- Hits 23192 23186 -6
- Misses 4798 4802 +4
- Partials 784 786 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nrcventura
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running in Serverless mode, the Agent License Key is not required to be set (either in config or via an environment variable).
This PR fixes #2499 by adding a check for serverless mode in
AgentManager.AssertAgentEnabled(). Additionally, when browser monitoring is enabled but the license key is not set, we now log a message rather than throwing an exception.