Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent should always create the "error" intrinsics attribute #500

Closed
vuqtran88 opened this issue Mar 17, 2021 · 0 comments · Fixed by #501
Closed

Agent should always create the "error" intrinsics attribute #500

vuqtran88 opened this issue Mar 17, 2021 · 0 comments · Fixed by #501
Assignees
Labels
bug Something isn't working

Comments

@vuqtran88
Copy link
Contributor

vuqtran88 commented Mar 17, 2021

Description
In the event of error occurs in a transaction, the agent create the "error" intrinsics attribute and set its value to "true" in it for transaction event. However, It doesn't create this attribute for "normal" transactions.

Expected Behavior
Agent creates the "error" intrinsics attribute for transaction events with/without errors and set the value appropriately.

Your Environment
[TIP]: # ( Include as many relevant details about your environment as possible including the running version of the agent and any relevant configurations, such as the .NET framework or core version of your application. )

Additional context
Refs:

https://pages.datanerd.us/engineering-management/architecture-notes/notes/123/#error-tracking

After discussing with other agent engineers, sees the below:

  • Python and Ruby agents also don't send error attribute with false value while Java agent does. I haven't gotten the responses from the rest of other team. The reasons are:

       1. There are other New Relic components that we don't own that might rely on just the present of this attribute. This might no longer be true as I check with distributed tracing team.
       
       2. We're not supposed to send values who's value is the same as the implicit/default value even though this is definitely not obvious to customers.
    
  • Even though I created a bug there, but it will require some coordination with other agents as this will be a breaking change for some customers (null value error attribute will no longer be there if we decided to fix.). However, the spec is clear when the spec is clear on what it should be. It won't be an immediate breaking change since customers would have to update to get the fix. We need to do good communication with the customers if we decided to make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants