Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate workflows to use Node 20 #1517

Closed
meiao opened this issue Sep 25, 2023 · 3 comments
Closed

Migrate workflows to use Node 20 #1517

meiao opened this issue Sep 25, 2023 · 3 comments
Assignees
Labels
2 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter

Comments

@meiao
Copy link
Contributor

meiao commented Sep 25, 2023

Description

GHA is migrating its workflows to use Node 20 by Spring 2024. This will break some external actions that we use, so they'll need to be updated.
This will likely affect all repositories, not just the newrelic-java-agent.

Acceptance Criteria

No warnings about Node 16 show up in actions.

@meiao meiao added the jan-mar qtr Represents proposed work item for the Jan-Mar quarter label Sep 25, 2023
@kford-newrelic kford-newrelic added the estimate Issue needing estimation label Sep 25, 2023
@workato-integration
Copy link

@meiao
Copy link
Contributor Author

meiao commented Dec 12, 2023

Currently there are no warning messages about Node 16.
Also it is not guaranteed that all actions that we use already have a version running with Node 20 at this point.

Announcement about the change:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Previously, the changes needed were mostly bumping up versions of the actions: checkout and setup-java.

@kford-newrelic kford-newrelic added 2 Story Point Estimate and removed jan-mar qtr Represents proposed work item for the Jan-Mar quarter estimate Issue needing estimation labels Dec 12, 2023
@meiao
Copy link
Contributor Author

meiao commented Mar 7, 2024

https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Looks like the date they'll start enforcing Node 20 use is May 13.

@kford-newrelic kford-newrelic added the apr-jun qtr Represents proposed work item for the Apr-Jun quarter label Mar 7, 2024
@newrelic newrelic deleted a comment from workato-integration bot Mar 7, 2024
@deleonenriqueta deleonenriqueta self-assigned this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter
Projects
Archived in project
Development

No branches or pull requests

3 participants