Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a jsp-4 instrumentation module #1932

Closed
jtduffy opened this issue Jun 10, 2024 · 1 comment · Fixed by #1951
Closed

Create a jsp-4 instrumentation module #1932

jtduffy opened this issue Jun 10, 2024 · 1 comment · Fixed by #1951
Assignees
@jtduffy
Labels
2 Story Point Estimate

Comments

@jtduffy
Copy link
Contributor

jtduffy commented Jun 10, 2024

Description

The addition of JSP tag lib instrumentation for RUM script injection to the jsp-3 module caused the verify instrumentation task to start failing on jakarta.servlet.jsp:jakarta.servlet.jsp-api:4.0.0-M1. This is likely due to removal of deprecated methods on the JspWriter, PageContext and JspContext classes.

Acceptance Criteria

A new instrumentation module is created and applies to jakarta.servlet.jsp:jakarta.servlet.jsp-api:4.0.0-M1. This can probably be a copy of the jsp-3 module with minor modifications.
@jtduffy jtduffy added the estimate Issue needing estimation label Jun 10, 2024
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-279230

@jtduffy jtduffy self-assigned this Jun 14, 2024
@jtduffy jtduffy added 2 Story Point Estimate and removed estimate Issue needing estimation labels Jun 14, 2024
@jtduffy jtduffy mentioned this issue Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtduffy jtduffy

Labels
2 Story Point Estimate
Projects
Java Engineering Board
Status: Code Complete/Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JSP v4 module newrelic/newrelic-java-agent
1 participant
@jtduffy