Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioned tests break on 3.x of packages #103

Closed
bizob2828 opened this issue Jul 8, 2021 · 0 comments · Fixed by #106
Closed

versioned tests break on 3.x of packages #103

bizob2828 opened this issue Jul 8, 2021 · 0 comments · Fixed by #106

Comments

@bizob2828
Copy link
Member

Description

It looks like apollo server has started rolling out 3.0.0 and it's breaking our versioned tests. At first glance it's just around how we bootstrap the plugins with apollo-server. You can see a failed run here 3.0.0 Failed Versioned Run

Expected Behavior

All versioned tests pass on 3.x of all apollo-server plugins

Troubleshooting or NR Diag results

Steps to Reproduce

Run versioned tests

npm run versioned

Additional context

It looks like our helpers to setup a framework with apollo need tweaked. I was able to change hapi and it works in both 2.x and 3.x

--- a/tests/versioned/apollo-server-hapi/apollo-server-hapi-setup.js
+++ b/tests/versioned/apollo-server-hapi/apollo-server-hapi-setup.js
@@ -49,10 +49,9 @@ function setupApolloServerHapiTests({suiteName, createTests, pluginConfig}, conf
         port: 5000
       })

+      await server.start()
       await server.applyMiddleware({ app: hapiServer, path: graphqlPath })

-      await server.installSubscriptionHandlers(hapiServer.listener)
-
@bizob2828 bizob2828 added bug Something isn't working needs-triage and removed needs-triage labels Jul 8, 2021
@bizob2828 bizob2828 self-assigned this Jul 8, 2021
@bizob2828 bizob2828 added this to Triage Needed: Unprioritized Features in Node.js Engineering Board via automation Jul 8, 2021
@bizob2828 bizob2828 moved this from Triage Needed: Unprioritized Features to In progress: Issues being worked on in Node.js Engineering Board Jul 8, 2021
@michaelgoin michaelgoin added this to To Do in 1.0.0 - Naming and Node 16 / Drop 10 via automation Jul 9, 2021
@michaelgoin michaelgoin moved this from To Do to In Progress in 1.0.0 - Naming and Node 16 / Drop 10 Jul 9, 2021
@bizob2828 bizob2828 moved this from In progress: Issues being worked on to Needs PR Review in Node.js Engineering Board Jul 13, 2021
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Jul 13, 2021
1.0.0 - Naming and Node 16 / Drop 10 automation moved this from In Progress to Done Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging a pull request may close this issue.

1 participant